This is the mail archive of the crossgcc@sourceware.org mailing list for the crossgcc project.

See crosstool-NG for lots more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] to fix : crosstool-NG-1.18.0 - obsolete RPC headers are not installed for Glibc


Jérôme, All,

On Friday 15 February 2013 Jérôme BARDON wrote:
> Here is a patch to fix this :
> ================================================================
> # HG changeset patch
> # User Jerome BARDON <bardon.pro@gmail.com>
> # Date 1360923357 -3600
> # Node ID 367d677bfbeee5905310cbf0bf4636f76a786192
> # Parent  fb662f18d002da9303aba2ea933c5204b789e752
> also add RPC headers install for Glibc

The commit log should be a bit more explicit about what the changeset is
about (basically, what you added below the patch), and must include your
SoB-line (see: http://www.elinux.org/Developer_Certificate_Of_Origin ),
something like:

    libc/glibc: install obsolete RPC for both eglibc and glibc

    Currently, the obsolete RPC headers are only installed for eglibc,
    but glibc has the same /deficiency/, so install the obsolete RPC
    for both.

    Signed-off-by: Your Real Name <a.valid@email.address>

> diff -r fb662f18d002 -r 367d677bfbee scripts/build/libc/glibc-eglibc.sh-common
> --- a/scripts/build/libc/glibc-eglibc.sh-common Fri Feb 15 10:46:40 2013 +0100
> +++ b/scripts/build/libc/glibc-eglibc.sh-common Fri Feb 15 11:15:57 2013 +0100
> @@ -222,7 +222,9 @@
>              OPTIMIZE=-O2
>              # Also, if those two are missing, iconv build breaks
>              extra_config+=( --disable-debug --disable-sanity-checks )
> -            ;;
> +            # always include rpc, the user can still override it with TI-RPC
> +            extra_config+=( --enable-obsolete-rpc )
> +             ;;
>      esac

Rather than duplicate the code in both the glibc and the eglibc path, just
move the existing "extra_config+=" line just belose the "esac".

Thank you! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]