This is the mail archive of the crossgcc@sourceware.org mailing list for the crossgcc project.

See crosstool-NG for lots more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1 of 1] refine static linking check to better guide user


Daniel, All,

On Wednesday 21 November 2012 Daniel Price wrote:
> On Tue, Nov 20, 2012 at 3:15 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> >> -            # Not all tools are available for all platforms, but some are really,
> >> -            # bally needed
> >> +            # Not all tools are available for all platforms, but some are required.
> >
> > Gratuitous change with no real change in meaning.
> 
> There was a spelling error (bally) in the original comment; I'll drop
> it from my patch since it isn't crucial.

Ah yes, 'badly'. OK for your fix, then.

> > I really do not like the following. However, I don't see how we could make
> > it cleaner, given the overall design of this script. From the beginning,
> > I've been too lax when I wrote it.
> 
> I didn't love it either, but I thought that up-front sanity checking
> was an improvement.

Yes, but your next patch will be much cleaner! ;-)

> > Why can't we just simply run:
> >     CT_DoLog DEBUG "Testing blabla"
> >     CT_DoExecLog DEBUG "${CT_HOST}-gcc" -v
> 
> As for all the rest: You are right.  I'll rework to use the common
> infrastructure.  I wasn't familiar enough with the codebase, clearly.
> Thanks for the insightful review!

No problem. I really spent a lot of time on this, even testing some code
snippets in shell scripts, to come up with the alternate code construct,
to eventually realise that we already had all we needed with the error-
catching infra. Sigh..

/me goes to bed. ;-)

Thanks for working on this! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]