Re: [PATCH 0 of 1] Alternative debug-shell implementation

[Johannes Stezenbach <js at sig21 dot net>]

Hi Yann,

On Tue, Oct 16, 2012 at 08:53:29PM +0200, Yann E. MORIN wrote:
> On Tuesday 16 October 2012 Johannes Stezenbach wrote:
> > On Mon, Oct 15, 2012 at 09:53:55PM +0200, Yann E. MORIN wrote:
> > > Here is an alternate implementation of debug-shell, that I was working on
> > > following your previous submission.
> [--SNIP--]
> > > I was working on it, since you said "I'm out of time atm and can't finish it."
> > > Of course, your initial submission was of great help to come up with this
> > > alternate solution! Thank you! :-)
> > 
> > That's fine, I had a small amount of spare time yesterday and
> > brushed up my patches since it looked like noone else would do it.
> > But I like you version actually better than mine.
> > I'll test it soo but I can't make any promises as to when I get around...
> 
> OK, I'll wait a bit for your ACK, then. Thank you! :-)

My patch had this test:

+       if [ -t 0 -a -t 6 -a -t 2 ]; then
+              ...
+       else
+               CT_DoLog WARN "CT_DEBUG_CT_FIXUP_SHELL disabled due to I/O redirection"
+       fi

I haven't tested what happens if you run "c-ng build |& tee log" and
then try to run an interactive shell, but I guess it can't work?

Then, I'm running in this:

[INFO ]  Checking C library configuration
[ERROR]    You did not provide an eglibc config file!
[ERROR]
[ERROR]  >>
[ERROR]  >>  Build failed in step '(top-level)'
[ERROR]  >>
[ERROR]  >>  Error happened in: main[scripts/crosstool-NG.sh@585]


Current command (unknown), exited with error code: 1
Please fix it up and finish by exiting the shell with one of these values:
    1  fixed, continue with next build command
    3  abort build

ct-ng:~/tmp/tc/build>

Where scripts/crosstool-NG.sh@585 is "for step in ${CT_STEPS}; do".
I guess we can live with that but since there is no command
to fix or re-run it is a bit odd.


Best Regards
Johannes

--
For unsubscribe information see http://sourceware.org/lists.html#faq