This is the mail archive of the crossgcc@sourceware.org mailing list for the crossgcc project.

See the CrossGCC FAQ for lots more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1 of 2] cross-gdb: add XML support


Hi Yann, all!

> 2) Add a *_prepare function to the API, that gets call at the very
> beginning
>    of the build, and does the necessary checks. Eg.:
>      do_debug_gdb_prepare() {
>        if [ ! "${libexpat_available}" ]; then
>           Aaargh
>        fi
>      }
>   Do it everywhere.
>   Also, have ./configure do the has_or_warn (as per Bryan's
>   suggestion).
>   This is pretty nice, and lightweight. Rather easy to implement, I
>   think.

The has_or_warn part() of my new patch is ready. Do you prefer the
do_debug_gdb_prepare() that you proposed above, or rather something
like the following?

---
comment "Cross-gdb - disabled (requires expat)"
    depends on !CONFIGURE_has_expat

cconfig GDB_CROSS
    bool
    prompt "Cross-gdb"
    default y
    depends on CONFIGURE_has_expat
    select GDB_GDBSERVER if ! BARE_METAL
    help
      Build and install a cross-gdb for the target, to run on host.
---

I don't see the point of allowing the user to choose a configuration
that will fail as soon as the build starts.

Best regards,
BenoÃt

--
For unsubscribe information see http://sourceware.org/lists.html#faq


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]