Re: [patch 01/10] Force autoreconf for mpfr

[Remy Bohmer <linux at bohmer dot net>]

Hi Yann,

2010/5/29 Yann E. MORIN <yann.morin.1998@anciens.enib.fr>:
> Remy, All,
>
> On Thursday 27 May 2010 23:18:10 Remy Bohmer wrote:
>> In some exotic case the autoreconf step of mpfr is not executed (correctly)
>> leaving an incorrect version number for libtool in the configure script.
>>
>> After extracting the sources files, force autoreconf to be executed.
>>
>> Signed-off-by: Bart vdr. Meulen <bartvdrmeulen@gmail.com>
>> ---
>> ?scripts/build/companion_libs/mpfr.sh | ? ?2 +-
>> ?1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Index: crosstool-ng/scripts/build/companion_libs/mpfr.sh
>> ===================================================================
>> --- crosstool-ng.orig/scripts/build/companion_libs/mpfr.sh
>> +++ crosstool-ng/scripts/build/companion_libs/mpfr.sh
>> @@ -34,7 +34,7 @@ do_mpfr_extract() {
>> ? ? ? ? ? ? ?CT_Pushd "${CT_SRC_DIR}/mpfr-${CT_MPFR_VERSION}"
>> ? ? ? ? ? ? ?if [ ! -f .autoreconf.ct-ng ]; then
>> ? ? ? ? ? ? ? ? ?CT_DoLog DEBUG "Running autoreconf"
>> - ? ? ? ? ? ? ? ?CT_DoExecLog ALL autoreconf
>> + ? ? ? ? ? ? ? ?CT_DoExecLog ALL autoreconf -fi
>
> I'd like that you explain what those "exotic cases" are. The patch breaks
> the build on my machine (Debian Lenny + backports):
> ?# autoreconf --version
> ?autoreconf (GNU Autoconf) 2.65
> ?# libtool --version
> ?ltmain.sh (GNU libtool) 1.5.26 Debian 1.5.26-4+lenny1 (1.1220.2.493
> ?2008/02/01 16:58:18)

Oops that was indeed what you mentioned already earlier. I was to
focused on merging all the patches back in on top of mainline that I
forgot that this particular patch did not work on your system. IIRC
this patch had something to do with our build-server which is a RHEL5
machine, and the exotic case was probably related to this machine, but
Bart could maybe provide you some more info about it next week.

At least the complete series is merged back in again on top of the
current mainline and it is working properly.
Please take a look at the other patches and if those are okay, please
pull them in.

Kind regards,

Remy

--
For unsubscribe information see http://sourceware.org/lists.html#faq