Re: [Fwd: Re: [PATCH 1 of 3] arch: s390 and 390x glibc patch]

[Mike Frysinger <vapier at gentoo dot org>]

On Wednesday 11 November 2009 17:59:28 Harold Grovesteen wrote:
> Mike Frysinger wrote:
> >On Wednesday 11 November 2009 12:40:28 Harold Grovesteen wrote:
> >>--- a/scripts/build/libc/glibc.sh	Fri Oct 30 20:08:44 2009 +0100
> >>+++ b/scripts/build/libc/glibc.sh	Wed Nov 11 09:07:36 2009 -0600
> >>@@ -152,7 +152,8 @@
> >>     CT_DoExecLog ALL                                            \
> >>     "${CT_SRC_DIR}/glibc-${cvs}${CT_LIBC_VERSION}/configure"    \
> >>         --build="${CT_BUILD}"                                   \
> >>-        --host="${CT_TARGET}"                                   \
> >>+        --host="${CT_BUILD}"                                    \
> >>+        --target="${CT_TARGET}"                                 \
> >
> >not only is there no --target option for glibc, but it doesnt make any
> > sense for there to be one.  the C library doesnt generate code.
> >
> >setting the --host to the build system is also blatantly wrong.  i dont
> > see why you need either of these changes -- i cross-compile s390/s390x
> > just fine using the same method as all other targets.
> 
> To both Mike and Yann, this goes to the issue I ran into with
> --with-long-double-128.  Mike, I am glad you can confirm that you don't
> need this.  Now, why did I?  Mike what version of glibc are you using?
> Maybe that is a factor.  I used glibc 2.9.

glibc-2.9 was the last time i tried s390/s390x, and it didnt whine about long 
double issues.  when exactly did you hit troubles ?  during header install and 
thus no C compiler was yet available ?  under Gentoo, a bunch of cache vars 
are forced just for the headers step as there is no compiler to test.  those 
include mlong double tests.
	libc_cv_mlong_double_128=yes
	libc_cv_mlong_double_128ibm=yes

> Mike, are you using crosstool-ng for s390/s390x or your own implementation?

i dont believe ive used crosstool-ng before.  Gentoo has a cross-compiler 
generation tool integrated with its build scripts called crossdev.

> I will make the other recommended changes and remove this.  If the
> problem with long-double-128 returns I will post the results for
> examination.

that would be good
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.