Re: [PATCH] arch: s390 and 390x glibc patch

["Yann E. MORIN" <yann dot morin dot 1998 at anciens dot enib dot fr>]

Harold,
All,

On Wednesday 11 November 2009 16:51:38 Harold Grovesteen@dev.site, h.grovsteen@tx.rr.com wrote:
> # HG changeset patch
> # User harold@dev.site
> # Date 1257952056 21600
> # Node ID 4dfd56aa6ad7b752b3c3c420e350208b631598ce
> # Parent  187e06178dcbe8a15147bb057e7242d5dccd8309
> arch: s390 and 390x glibc patch
> 
> see s390.in and s390x.in for architecture URL pointers

This commit message does not match the following changes.
You can fix it with: qrefresh -e

> diff -r 187e06178dcb -r 4dfd56aa6ad7 scripts/build/debug/100-dmalloc.sh
> --- a/scripts/build/debug/100-dmalloc.sh	Fri Oct 30 20:08:44 2009 +0100
> +++ b/scripts/build/debug/100-dmalloc.sh	Wed Nov 11 09:07:36 2009 -0600
> @@ -41,6 +41,7 @@
>          --prefix=/usr                                           \
>          --build="${CT_BUILD}"                                   \
>          --host="${CT_TARGET}"                                   \
> +        --target="${CT_TARGET}"                                 \
>          "${extra_config[@]}"

The --target option is only needed for tools that understand three
machines:
 - build machine : the machine the compilation of the tool will take place
 - host machine  : the machine the tool will run
 - target machine: the machine the tool will generate/interpret code for

This applies only to a very few tools, namely: binutils, gcc and gdb.
The others tools (eg glibc, dmalloc, duma, and so on...) only know about
"build" and "host".

I really don't see why dmalloc would require --target at all. If it does,
then something in dmalloc is broken, and needs fixing, not crosstool-NG.

If dmalloc (and other debug tools) do not work out of the box, leave them
alone, we'll fix it once the core suport for s390{,x} is in.

>      CT_DoLog EXTRA "Building dmalloc"
> diff -r 187e06178dcb -r 4dfd56aa6ad7 scripts/build/libc/glibc.sh
> --- a/scripts/build/libc/glibc.sh	Fri Oct 30 20:08:44 2009 +0100
> +++ b/scripts/build/libc/glibc.sh	Wed Nov 11 09:07:36 2009 -0600
> @@ -134,7 +134,7 @@
>                     |sed -r -e 's/\<(nptl|linuxthreads)\>/ /g;'  \
>                             -e 's/ +/,/g; s/^,+//; s/,+$//;'     \
>                    )"
> -
> +    extra_config+=("${CT_LIBC_GLIBC_EXTRA_CONFIG}")

Please send this as a separate patch, that's a proper fix.

>      extra_config+=("--enable-add-ons=${addons_list}")
>  
>      extra_config+=("${addons_config}")
> @@ -152,7 +152,8 @@
>      CT_DoExecLog ALL                                            \
>      "${CT_SRC_DIR}/glibc-${cvs}${CT_LIBC_VERSION}/configure"    \
>          --build="${CT_BUILD}"                                   \
> -        --host="${CT_TARGET}"                                   \
> +        --host="${CT_BUILD}"                                    \

Nope, host is really CT_TARGET: that the machine on which the C library
will _run_.

> +        --target="${CT_TARGET}"                                 \

Ditto as for dmalloc. I don't see why --target is needed here.
(Note: the fact that newlib does use --target is because its comnfigure
script is kind of broken, and the doc explicitly says to use --target.)

>          --prefix=/usr                                           \
>          --with-headers="${CT_HEADERS_DIR}"                      \
>          --without-cvs                                           \

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
`------------------------------^-------^------------------^--------------------'



--
For unsubscribe information see http://sourceware.org/lists.html#faq