Re: arm-unknown-linux-gnueabi ABI selection

[Marc Kleine-Budde <mkl at pengutronix dot de>]

Yann E. MORIN wrote:
> On Thursday 28 August 2008 16:25:54 Michael Abbott wrote:
>> [ERROR]  ABI='aapcs-linux' not supported for EABI.
>> [ERROR]  If you know you are right, please edit 'arch/arm/functions' in 
>> crosstool-NG sources.
> 
> OK, we could add a new case entry to recognise aapcs-linux, and act as if
> it were in fact aapcs:
> 
>     case "${CT_ARCH_ABI},${CT_ARCH_ARM_EABI}" in
>         *,) ;;
>         aapcs,y)
>             CT_DoLog DEBUG "'--with-abi=aapcs' is in fact '-mabi=aapcs-linux' when used in CFLAGS."
>             CT_ARCH_ABI_CFLAGS="-mabi=aapcs-linux"
>             ;;
>         aapcs-linux,y)
>             CT_DoLog DEBUG "'-mabi=aapcs-linux' is in fact '--with-abi=aapcs' when used in ./configure flags"
>             CT_ARCH_WITH_ABI="--with-abi=aapcs"
>             ;;
>         ,y)
>             CT_DoLog WARN "Forcing ABI to 'aapcs-linux' for use with EABI."
>             CT_ARCH_WITH_ABI="--with-abi=aapcs"
>             CT_ARCH_ABI_CFLAGS="-mabi=aapcs-linux"
>             ;;
>         *,y)
>             CT_DoLog ERROR "ABI='${CT_ARCH_ABI}' not supported for EABI."
>             CT_Abort "If you know you are right, please edit 'arch/arm/functions' in crosstool-NG sources."
>             ;;
>     esac
> 
> Thoughts?

Just a simple question, why are you fiddeling around with --with-abi or
-mabi flags in the first place?

If a toolchain target touple is "arm-unknown-linux-gnu" the toolchain
becomes an oabi (old ABI) toolchain, whereas
"arm-whatever-linux-gnueabi" produces an eabi toolchain. Magically, no
need for these manual flags.

cheers, Marc

-- 
 Marc Kleine-Budde              Phone: +49-231-2826-924
 Pengutronix - Linux Solutions for Science and Industry
 Vertretung West/Dortmund     http://www.pengutronix.de

Attachment: signature.asc
Description: OpenPGP digital signature