Re: [PATCH] to not include a currently-included file in sanitizedheaders

["Robert P. J. Day" <rpjday at mindspring dot com>]

On Tue, 3 May 2005, Dan Kegel wrote:

> Robert P. J. Day wrote:
> > > When you post patches, though, could you include the
> > > error message that it fixes?
> >
> >
> > good point, and perhaps you can clarify something.  if you use just
> > the sanitized headers and not the full kernel source, obviously you're
> > not going to do any configuration and, consequently, if you look under
> > the include/ directory, you'll see all of:
> >
> >   asm-alpha/
> >   asm-arm/
> >   asm-arm26/
> >
> > and so on.  however, because of no configuration, you'll never have
> > the appropriate symlink, say, asm->asm-sh.
> >
> > what that means is that you better never incorporate a header file
> > that contains anything of the form:
> >
> >   #include <asm/whatever.h>
> >
> > since it's guaranteed to fail.  that's what happened with
> > include/asm-sh/ptrace.h -- it included <asm/ubc.h> and choked.  so
> > just commenting out that single include directive was the patch.
>
> I think you must have missed the crucial line from crosstool.sh:
>   cp -r include/asm-${ARCH} $HEADERDIR/asm
> Did you use the sanitized header support built into crosstool-0.32?
> I suspect not...

sorry, just me being an airhead again.  in the include/asm-sh
directory, there simply *is* no "ubc.h" file, which is why (based on
an earlier email from mariusz) he's simply removing that single
include directive in ptrace.h from the next version of the headers.

so, yes, you need that patch.  and i need more coffee.

rday

------
Want more information?  See the CrossGCC FAQ, http://www.objsw.com/CrossGCC/
Want to unsubscribe? Send a note to crossgcc-unsubscribe@sources.redhat.com