Re: [patch][rfa]: Decoding (not-so) ambiguous insns in sid/sim

["Frank Ch. Eigler" <fche at redhat dot com>]

Hi -

brolley wrote:
> [...]
> >By the way, have you tried the "funny function" above?  It would have
> >the property of separating the 0/0 and 0/N cases [...]
> >
> Yes, I considered the "funny function" but rejected it because it 
> assigns a non-zero value in the case where a given bit must always be 1 
> or always 0, e.g. p0==num_insns,p1==0. Such a bit is useless for 
> decoding purposes and is correctly assigned a value of zero both by the 
> old function and by my new function.

You mean that there are actually four separate cases to consider?

p0=X, p1=Y, num_insns=N

	X=0 / Y=0	==> result = 0
	X<N / Y=0	==> 0 < result < N
	X=N / Y=0	==> result = 0
	X!=0 / Y!=0	==> result >= N

Okay.  Tricky.

> Can I consider your response to be approval to commit?

Sure.

> What about "filter-harmlessly-ambiguous-insns"? 
> Should I remove it from insn.scm?

No opinion.


- FChE

Attachment: msg00003/pgp00000.pgp
Description: PGP signature