This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch 0/2] [binutils][arm] Armv8-M Custom Datapath Extension.
- From: Matthew Malcomson <matthew dot malcomson at arm dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: binutils <binutils at sourceware dot org>
- Date: Tue, 11 Feb 2020 10:51:27 +0000
- Subject: Re: [Patch 0/2] [binutils][arm] Armv8-M Custom Datapath Extension.
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jbppb8m7nOU+AkwUcVRt84Cj/N5mTokqr02OrC4RRwQ=; b=nI7IdkV89Ma0Nw41pOaExqv/7ZMNmOSaXAFH2IK9jemP3CGYHtMqtVsmEeC4bu/sDULLcOVXyh/LnaXgjEQSQjtw72DfuuUXJrqHQSI+ls52GEnUBkJLZmu5o5IvXD0yL3/rkk5k0079h5RmZa8cYISYfAUsNmWH3giGt3n/o+Qo+RxChw7vVvpG1MM4OWwEw8EQIfoFZc93zx4JvmItACO+ASUjy4FbOCc/nQQtpE2ntbUDMTW8cOoSUcTYjZJqhdAwHQqwZtiOUle4MNKKS3bOfSOhDAstOC2ePya2wQHI7hVH9eCLa1W0Yz+1eKg+gcvD9R2hhN5yFGneT+nhAg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f665nyoKPGqZfT4bYW22BoKCVEDlqog4FnqudJd8BcGWvMPt7h//vqowThsQWx64t6vzaKMR3S59UlaRmIVjIVhlfvW4Bw8DkneteRBdMUptgUzR2c8+CyEdH2mRKI0PCjCGvf0K9fynQIBxFwglcozr+vZF1Z+vQgqVoZnlQS4bEecME9PcPdCK8eq05EhYywI7QlrAyw4GzRnOnYRA6Q7GAoezmjBz7nZ7BrnNJwVV5ffbyaNbOTSFIA348DHWeI1LxOtW3UNi8nJ2+OjJV13PxFTOG45TQahExyutEtQ9otGxJ12R5Dejmg8/XetOwrQVfLMTCRUhKLa5/DfpIw==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Matthew dot Malcomson at arm dot com;
- References: <158133346517.10770.13178331135147729297.scripted-patch-series@arm.com> <59ab928b-5311-e7c0-d9a1-16f76029b190@redhat.com> <CAKdteObwg_bfnSMdS4W=95as14=Q5nVTDWNWMwVE=qoaC9E3dw@mail.gmail.com>
On 10/02/2020 21:50, Christophe Lyon wrote:
On Mon, 10 Feb 2020 at 16:11, Nick Clifton <nickc@redhat.com> wrote:
Hi Matthew,
The patch is in two parts:
Part 1 enables the scalar instructions, which are predicated on *either*
Armv8-m with the floating point extension *or* Armv8.1-m with the MVE
extension.
Part 2 enables the vector instructions which are dependent on Armv8.1-m with
MVE.
Part 1 was worked on by both me and Stam Markianos-Wright.
The patch series has been successfully regression tested on arm-none-eabi and
arm-wince-pe.
Ok for master?
Yes - please apply.
Hi,
One of these two patches causes a build failure for gas. I'm seeing:
../../gas/config/tc-arm.c: In function ‘vcx_handle_register_arguments’:
../../gas/config/tc-arm.c:21985:3: error: ‘for’ loop initial
declarations are only allowed in C99 mode
for (unsigned i = 0; i < num_registers; i++)
^
../../gas/config/tc-arm.c:21985:3: note: use option -std=c99 or
-std=gnu99 to compile your code
make[4]: *** [config/tc-arm.o] Error 1
Can you fix it?
Thanks
Christophe
Wow!
I'm really sorry about that.
I've committed the fix as obvious, but I'd like to double check what
went wrong here to ensure I avoid it in the future.
My best guess for the problem is that I compile with gcc 5 which has a
default standard of gnu11, while you're testing with an earlier gcc
which has a default standard of gnu89.
Does that fit? (i.e. are you using an older gcc?)
I will use `-std=gnu89` from now on.
Regards, and apologies again:
MM
Cheers
Nick