This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] configure: Re-disable building cross-gdbserver
- From: "Maciej W. Rozycki" <macro at wdc dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org, binutils at sourceware dot org
- Date: Sat, 8 Feb 2020 16:21:12 +0000 (GMT)
- Subject: [PATCH] configure: Re-disable building cross-gdbserver
- Ironport-sdr: wrFxyhjehpL6g5do4OimB6mYP7ke19L9YlawjsFeEDGBPH2KmgTN9Wjumb/FnRzDggkmdLTwK5 mTUR9WFILmrmCCsS1rA/aX5TFF3QIsfInZB9ai/HWqDBpP0UvFpwgb54h43LGCZraudIMaJTCQ srVIDMTf2zHQbT8CTPqJZX2Upf5+gu0wJWT9XNa6nj3gVfNDW83680e98fjfazE8n0g7ypobLx 6eYkc0sQ3mzci7VrtepfJ5DbPHb/8NcqY3Klv8O8y+RRTfCwcsNdpWo2iDN9WJj2PbRfOemjfB JS8=
- Ironport-sdr: rfVgMtP0irqt5zndzVKGsp3hX76az1AGLbx8s1bP6m8EA2yHzA24PSvYjHajAGTJRF8v1JjYOJ Wdt83fw7XZmeqk7vcJHHaPhcwSISoq2eS8BIpSBBcH3E7CM+Rt5xQ85rN0HiFgQNDlnviz/A/C 1MWD75d4kBvM9KN/7nTAq0cb9ztisSLqpjy42fjc3gVoUwtX7Duy+B1nPb+jG3Wog+CaROihra 3dxA2BmSaT4yvS21Lu717E6Ma97S7K2TgXuG3fQOdSlXden3wpqJOIvPFyNFZA36cP5cnFijgn rhkDN8Bo75tsFtrg2XAUtAPd
- Ironport-sdr: ExyP020YsChlrVeABqL92bpSCpdaw+o5xoxfc+orAZTCdNTxlbKJp9c4Mf4IXomFE/l9ATk02H o908yqsQ/jygOLNbgeVjfrSEcjGO8qpNbecjt45i0Llj9G0LVuUbq3RFAKxPdwptIvovTufKR0 15lv7+YiYq2jvHsCzm/CuKzIIC72lAB7DvI1vdOMHajQy8tir7lcRrI0rVzyHOLtYoovmLIUxU O8muWKXvbQ15fhxXhAiZHv/ex/6EoZtFfWKqAtl026GXKg8K3AUUjk17/t9wx+IXhWukXpliHi CQE=
- Wdcironportexception: Internal
Correct fallout from commit 919adfe84092 ("Move gdbserver to top level")
and revert to not building `gdbserver' in a cross-configuration, that is
where host != target, matching the documented behaviour. We have no way
to support non-native `gdbserver', and native `gdbserver' is usually of
no use with cross-GDB of the chosen host.
* configure.ac: Do not build `gdbserver' if $is_cross_compiler.
* configure: Regenerate.
---
Hi,
Verified with a native build, a crossed build of a native configuration
and a build of a cross-debugger; Canadian Cross not checked. OK to apply?
NB I have noticed that the gdbserver(1) man page is still being built and
installed (as ${target_alias}-gdbserver.1, if building a cross-debugger),
even if `gdbserver' itself is not (and it is not built if only `gdbserver'
is while GDB is not). Obviously this is due to the man page still living
under gdb/doc/, and I presume it will be addressed sometime soon, by
moving the man page somewhere under gdbserver/, right?
Also there are currently a number of mismatches in configure.ac between
the gcc and the binutils-gdb repositories; what is the plan to eliminate
them?
Maciej
---
configure | 5 +++--
configure.ac | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
gdbserver-no-cross.diff
Index: binutils-gdb/configure
===================================================================
--- binutils-gdb.orig/configure
+++ binutils-gdb/configure
@@ -3538,12 +3538,13 @@ case "${target}" in
;;
esac
-# Only allow gdbserver on some systems.
+# Only allow native gdbserver and then only on some systems.
if test -d ${srcdir}/gdbserver; then
if test x$enable_gdbserver = x; then
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for gdbserver support" >&5
$as_echo_n "checking for gdbserver support... " >&6; }
- if (srcdir=${srcdir}/gdbserver; \
+ if test x${is_cross_compiler} = xyes \
+ || (srcdir=${srcdir}/gdbserver; \
. ${srcdir}/configure.srv; \
test -n "$UNSUPPORTED")
then
Index: binutils-gdb/configure.ac
===================================================================
--- binutils-gdb.orig/configure.ac
+++ binutils-gdb/configure.ac
@@ -782,11 +782,12 @@ case "${target}" in
;;
esac
-# Only allow gdbserver on some systems.
+# Only allow native gdbserver and then only on some systems.
if test -d ${srcdir}/gdbserver; then
if test x$enable_gdbserver = x; then
AC_MSG_CHECKING([for gdbserver support])
- if (srcdir=${srcdir}/gdbserver; \
+ if test x${is_cross_compiler} = xyes \
+ || (srcdir=${srcdir}/gdbserver; \
. ${srcdir}/configure.srv; \
test -n "$UNSUPPORTED")
then