This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH 1/4] Arm64: correct 64-bit element fmmla encoding
- From: Tamar Christina <Tamar dot Christina at arm dot com>
- To: Jan Beulich <JBeulich at suse dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Mihail Ionescu <Mihail dot Ionescu at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, nd <nd at arm dot com>
- Date: Mon, 30 Dec 2019 11:37:17 +0000
- Subject: RE: [PATCH 1/4] Arm64: correct 64-bit element fmmla encoding
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UZ6vM+/36OhWv+f1tvgh6OxxNTssFgiJjoxqnO21FsM=; b=O2974gaBIpTQxc8qNjPxlL5Xx5dkSpgDlzuusyD1Hr02IjcOD/B/XLQm5D2lDlkwm40UWMjH8t9w3fz/RrwiJSoX/n/y1h05jQshY4pIhGritzloVsHkPRs/CtQm63Qc8GN1RRDZuw0TdZf4pqn/Px63J/VNpdJyu1EfdB/+0E1XctYaDSQ6SLJcrD/38jM7RHfobd2ch+EhyGUfjwYBndxcCvK0byHaNbcaRYvA8Q6M632dZfxkrQnlUxFUYVEDX0QbdP0biXYJo/pWsTZW3fNq85lGqtz5K21fSbqd7oL8AAH5U4j3v+XjUDk31akAx6oIVeL9PnEYqHiD6Ljvnw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZZB45M4gNZ5Ogzbgw2FDb6xOtqeTr73Xcm2QPN9/XshiITB6CtpWxDinaR7ecbKJ3/Grc36yTBhzTZdc/5za1I8QaJUxw2yWpBESafGnfbGFF6RjTRblSDKAFzcEsP3nhfFMod4r0xOvQkkbf7b8jcCqQKXS0k3Pg6eTg/FIc9fBTyVZyIjF+n8KlTSaHOo+IzMs3qm6WyCgYjf8V92H6Dgmz7kjOEe2BHy/q9TF4HH4xymhzgKGuDMnBf6He5URf8Gme2MNIBHGf6ruLWw9StIriYEqEWNRW6bjs4cm4aGzNcz3A6lmih8RRp1Y2pBPPxUFePzP6qSAZn7QrNPVjA==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tamar dot Christina at arm dot com;
- References: <37213fea-ae2e-0293-a042-9db2274cd061@suse.com> <053d5416-69f7-9692-01c0-7b7e3d9da85a@suse.com>
Hi Jan,
I'm not a maintainer so you still need approval to commit but this change is correct.
Thanks for the fix!,
Tamar
> -----Original Message-----
> From: binutils-owner@sourceware.org <binutils-owner@sourceware.org>
> On Behalf Of Jan Beulich
> Sent: Friday, December 27, 2019 10:39
> To: binutils@sourceware.org
> Cc: Marcus Shawcroft <Marcus.Shawcroft@arm.com>; Mihail Ionescu
> <Mihail.Ionescu@arm.com>; Richard Earnshaw
> <Richard.Earnshaw@arm.com>
> Subject: [PATCH 1/4] Arm64: correct 64-bit element fmmla encoding
>
> There's just one bit of difference to the 32-bit element form, as per the
> documentation.
>
> gas/
> 2020-01-XX Jan Beulich <jbeulich@suse.com>
>
> * testsuite/gas/aarch64/f64mm.d,
> testsuite/gas/aarch64/sve-movprfx-mm.d: Adjust expectations.
>
> opcodes/
> 2020-01-XX Jan Beulich <jbeulich@suse.com>
>
> * opcodes/aarch64-tbl.h (aarch64_opcode_table): Correct 64-bit
> FMMLA encoding.
> * opcodes/aarch64-dis-2.c: Re-generate.
>
> --- a/gas/testsuite/gas/aarch64/f64mm.d
> +++ b/gas/testsuite/gas/aarch64/f64mm.d
> @@ -6,8 +6,8 @@
> Disassembly of section \.text:
>
> 0+ <\.text>:
> - *[0-9a-f]+: 64dbe6b1 fmmla z17\.d, z21\.d, z27\.d
> - *[0-9a-f]+: 64c0e400 fmmla z0\.d, z0\.d, z0\.d
> + *[0-9a-f]+: 64fbe6b1 fmmla z17\.d, z21\.d, z27\.d
> + *[0-9a-f]+: 64e0e400 fmmla z0\.d, z0\.d, z0\.d
> *[0-9a-f]+: a43b17f1 ld1rob {z17\.b}, p5/z, \[sp, x27\]
> *[0-9a-f]+: a42003e0 ld1rob {z0\.b}, p0/z, \[sp, x0\]
> *[0-9a-f]+: a4bb17f1 ld1roh {z17\.h}, p5/z, \[sp, x27\]
> --- a/gas/testsuite/gas/aarch64/sve-movprfx-mm.d
> +++ b/gas/testsuite/gas/aarch64/sve-movprfx-mm.d
> @@ -21,4 +21,4 @@ Disassembly of section \.text:
> *[0-9a-f]+: 0420bc11 movprfx z17, z0
> *[0-9a-f]+: 64bbe6b1 fmmla z17\.s, z21\.s, z27\.s
> *[0-9a-f]+: 0420bc11 movprfx z17, z0
> - *[0-9a-f]+: 64dbe6b1 fmmla z17\.d, z21\.d, z27\.d
> + *[0-9a-f]+: 64fbe6b1 fmmla z17\.d, z21\.d, z27\.d
> --- a/opcodes/aarch64-tbl.h
> +++ b/opcodes/aarch64-tbl.h
> @@ -5073,7 +5073,7 @@ struct aarch64_opcode aarch64_opcode_tab
> INT8MATMUL_SVE_INSNC ("usdot", 0x44a01800, 0xffe0fc00, sve_misc,
> OP3 (SVE_Zd, SVE_Zn, SVE_Zm3_INDEX), OP_SVE_SBB, 0,
> C_SCAN_MOVPRFX, 0),
> INT8MATMUL_SVE_INSNC ("sudot", 0x44a01c00, 0xffe0fc00, sve_misc,
> OP3 (SVE_Zd, SVE_Zn, SVE_Zm3_INDEX), OP_SVE_SBB, 0,
> C_SCAN_MOVPRFX, 0),
> F32MATMUL_SVE_INSNC ("fmmla", 0x64a0e400, 0xffe0fc00, sve_misc,
> OP3 (SVE_Zd, SVE_Zn, SVE_Zm_16), OP_SVE_VVV_S, 0, C_SCAN_MOVPRFX,
> 0),
> - F64MATMUL_SVE_INSNC ("fmmla", 0x64c0e400, 0xffe0fc00, sve_misc,
> OP3 (SVE_Zd, SVE_Zn, SVE_Zm_16), OP_SVE_VVV_D, 0, C_SCAN_MOVPRFX,
> 0),
> + F64MATMUL_SVE_INSNC ("fmmla", 0x64e0e400, 0xffe0fc00, sve_misc,
> OP3 (SVE_Zd, SVE_Zn, SVE_Zm_16), OP_SVE_VVV_D, 0, C_SCAN_MOVPRFX,
> 0),
> F64MATMUL_SVE_INSN ("ld1rob", 0xa4200000, 0xffe0e000, sve_misc, OP3
> (SVE_ZtxN, SVE_Pg3, SVE_ADDR_RX), OP_SVE_BZU, F_OD(1), 0),
> F64MATMUL_SVE_INSN ("ld1roh", 0xa4a00000, 0xffe0e000, sve_misc, OP3
> (SVE_ZtxN, SVE_Pg3, SVE_ADDR_RX), OP_SVE_HZU, F_OD(1), 0),
> F64MATMUL_SVE_INSN ("ld1row", 0xa5200000, 0xffe0e000, sve_misc, OP3
> (SVE_ZtxN, SVE_Pg3, SVE_ADDR_RX), OP_SVE_SZU, F_OD(1), 0),