This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: V3 [PATCH 2/4] i386: Align branches within a fixed boundary
On 10.12.2019 17:19, H.J. Lu wrote:
> On Mon, Dec 9, 2019 at 6:54 AM Jan Beulich <jbeulich@suse.com> wrote:
>> On 06.12.2019 20:10, H.J. Lu wrote:
>>> +/* Return 1 if a BRANCH_PREFIX frag should be generated. */
>>> +
>>> +static int
>>> +add_branch_prefix_frag_p (void)
>>> +{
>>> + /* NB: Don't work with COND_JUMP86 without i386. Don't add prefix
>>> + to PadLock instructions since they include prefixes in opcode. */
>>> + if (!align_branch_power
>>> + || !align_branch_prefix_size
>>> + || now_seg == absolute_section
>>> + || i.tm.cpu_flags.bitfield.cpupadlock
>>
>> Didn't you confirm you'd take care of here of other insns than just
>> the PadLock ones including prefixes in their base_opcode? (I still
>
> I added the check for i.tm.opcode_length. PadLock is the only
> exception.
I don't see any such check, nor how PadLock would be an exception.
The comment also talks about PadLock only. Please clarify.
Jan