This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] [PR ld/22263][PR ld/25056] arm: Avoid dynamic TLS relocs in PIE
- From: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- To: Binutils <binutils at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Fri, 4 Oct 2019 09:38:34 +0000
- Subject: [PATCH] [PR ld/22263][PR ld/25056] arm: Avoid dynamic TLS relocs in PIE
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vvm22nZmqPsT2qG2fHBrjib8B3ijRRCvOC9OLjrbnnk=; b=B4+s+xup9cZKJfiyiul2wyz47scjG1noZQbDGLGyeKVufnTJeEuA7UPqt1r147bHXAfCONg2DsV9wTopw5Qtrd/Ad8z10t+A5BHmjWFee310vWJfb73CTYtrjIF/CAXDC0iLwG3PFW3nPdZd0K1SMFsfZHfv4dRjbg7OhVrPMg54zyFP6iNU9tGLskK3ICJpfBfXU7n76I5I3zUbVE8lFK1hGwqZgTy3V2Xpr9hlmSeygr7b7VIVa/7HfyC0jkZp+j+VwSKXDU9tB0a5j8fqLhQY3x1bgz8GzbeTYGVOLAX57KAcCP0/IqKpOZ5lDPy2SScqA7k3RTLWL3CEgcKpPg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jAkf1sRX9gSMyEX5f04KkjzdxjQNlTA4cKyHeURMDyGwDb3qDeD38z4GxF6RQc9BqYLvLCfjh2J2pg/GXmZTPC8iejpuWuXyE+n26a3SWiulWG/5/O8kuzSl0ltBjCQoO30BZI8szWoPDR+27JCLzzVHU/REGRn42j5xDigAw3uvSm/jSqFWYiZMQF20HnHkMimMDsGPd1HBLQ55yXMPsGh3CuXQy6tegflqJ8Fyhzs1cpbRjJJVNWWTmd98aKzZpgQAndll83Wd5WjE7vwKYMTDwfmgDRFQpoldKZrTYd6a/9l0OO3CFr79Dwvl4BLUATPdGQI/q+OjncyZxsDRXQ==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
Fixes incorrect TLS relocs in pie and allows TLS relaxation in pie.
OK to commit and later backport?
From 7d6e280a0f3b9978b0edb20173d067d071531a3d Mon Sep 17 00:00:00 2001
From: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date: Wed, 2 Oct 2019 19:46:46 +0100
Subject: [PATCH] [PR ld/22263][PR ld/25056] arm: Avoid dynamic TLS relocs in
PIE
Dynamic relocs are only needed in an executable for TLS symbols if
those are defined in an external module and even then TLS access
can be relaxed to use IE model instead of GD.
Several bfd_link_pic checks are turned into bfd_link_dll checks
to fix TLS handling in PIE, for the same fix some other targets
used !bfd_link_executable checks, but that includes relocatable
objects so dll seems safer (in most cases either should work, since
dynamic relocations are not applied in relocatable objects).
On arm* fixes
FAIL: Build pr22263-1
bfd/
2019-10-02 Szabolcs Nagy <szabolcs.nagy@arm.com>
PR ld/22263
PR ld/25056
* elf32-arm.c (elf32_arm_tls_transition): Use bfd_link_dll instead of
bfd_link_pic for TLS checks.
(elf32_arm_final_link_relocate): Likewise.
(allocate_dynrelocs_for_symbol): Likewise.
---
bfd/elf32-arm.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
index bb53e039e3..451949d278 100644
--- a/bfd/elf32-arm.c
+++ b/bfd/elf32-arm.c
@@ -4914,7 +4914,7 @@ elf32_arm_tls_transition (struct bfd_link_info *info, int r_type,
{
int is_local = (h == NULL);
- if (bfd_link_pic (info)
+ if (bfd_link_dll (info)
|| (h && h->root.type == bfd_link_hash_undefweak))
return r_type;
@@ -11700,7 +11700,7 @@ elf32_arm_final_link_relocate (reloc_howto_type * howto,
{
/* If we don't know the module number, create a relocation
for it. */
- if (bfd_link_pic (info))
+ if (bfd_link_dll (info))
{
Elf_Internal_Rela outrel;
@@ -11804,7 +11804,7 @@ elf32_arm_final_link_relocate (reloc_howto_type * howto,
now, and emit any relocations. If both an IE GOT and a
GD GOT are necessary, we emit the GD first. */
- if ((bfd_link_pic (info) || indx != 0)
+ if ((bfd_link_dll (info) || indx != 0)
&& (h == NULL
|| (ELF_ST_VISIBILITY (h->other) == STV_DEFAULT
&& !resolved_to_zero)
@@ -11821,7 +11821,7 @@ elf32_arm_final_link_relocate (reloc_howto_type * howto,
/* We should have relaxed, unless this is an undefined
weak symbol. */
BFD_ASSERT ((h && (h->root.type == bfd_link_hash_undefweak))
- || bfd_link_pic (info));
+ || bfd_link_dll (info));
BFD_ASSERT (globals->sgotplt_jump_table_size + offplt + 8
<= globals->root.sgotplt->size);
@@ -16494,7 +16494,7 @@ allocate_dynrelocs_for_symbol (struct elf_link_hash_entry *h, void * inf)
indx = h->dynindx;
if (tls_type != GOT_NORMAL
- && (bfd_link_pic (info) || indx != 0)
+ && (bfd_link_dll (info) || indx != 0)
&& (ELF_ST_VISIBILITY (h->other) == STV_DEFAULT
|| h->root.type != bfd_link_hash_undefweak))
{
--
2.17.1