This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: RFC: Make dotnet assemblies test more robust
- From: Omair Majid <omajid at redhat dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 06 Aug 2019 09:17:09 -0400
- Subject: Re: RFC: Make dotnet assemblies test more robust
- References: <20190626185416.GA10764@redhat.com> <e741f548-0d4b-9c05-2718-fd5b5c3317ec@redhat.com> <20190704044309.GA17004@redhat.com> <0d1b9c83-832e-87e1-1a0a-0a3372341582@redhat.com> <87k1cftf0n.fsf@redhat.com> <37a1c2a3-ce42-8041-e0a9-5eb6adaf388b@redhat.com> <87tvbckeyi.fsf@redhat.com> <5f0a76eb-3a21-a0cf-cafb-283bde7f2dcd@redhat.com> <87y30llo2y.fsf@redhat.com> <87tvb9lb6i.fsf@redhat.com>
Omair Majid <omajid@redhat.com> writes:
> Omair Majid <omajid@redhat.com> writes:
>
>> Nick Clifton <nickc@redhat.com> writes:
>>
>>> I think that what we need to do is to extend gentestdlls.c so that
>>> it generates a normal x86 PE dll file as well. Then the test can
>>> be extended to check this file first. If the target objdump is
>>> able to parse this file, then it should be able to parse the other
>>> two files as well. If it cannot then there is an error. (Actually
>>> 32-bit PE toolchains may only be able to parse one of the new .NET
>>> PE dlls).
>>
>> Thanks for the idea! How does the attached patch look?
>
> Oops. I just realized that I made a mistake in strcmp. Fixed now.
>
> binutils/ChangeLog:
>
> 2019-07-25 Omair Majid <omajid@redhat.com>
>
> * testsuite/binutils-all/objdump.exp
> (test_objdump_dotnet_assemblies): Fix test to distinguish errors
> in parsing simple pei-i386 and pei-x86-64 vs parsing the newly
> introduced machine types.
> * testsuite/gentestdlls.c (write_simple_dll): New function.
> (main): Generate simple and Linux-specific variants of pei-i386
> and pei-x86-64 files so both can be used by tests.
Ping?
Thanks,
Omair
--
PGP Key: B157A9F0 (http://pgp.mit.edu/)
Fingerprint = 9DB5 2F0B FD3E C239 E108 E7BD DF99 7AF8 B157 A9F0