This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix GCC9 warning on elf32-arm.c:elf32_arm_final_link_relocate
- From: Nick Clifton <nickc at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, binutils at sourceware dot org
- Date: Mon, 28 Jan 2019 12:41:07 +0000
- Subject: Re: [PATCH] Fix GCC9 warning on elf32-arm.c:elf32_arm_final_link_relocate
- References: <20190121204113.22669-1-sergiodj@redhat.com> <87ef8xqyj7.fsf@redhat.com>
Hi Sergio,
> Ping.
Sorry - I meant to reply last week, but got distracted.
>> The fix is (apparently) simple: instead of using 'labs', we should use
>> 'llabs', since we're passing a 'bfd_signed_vma' to it, which is at
>> least a 'long long int', as far as I have checked. This is what this
>> patch does.
>>
>> OK to apply?
Yes - approved - please apply.
Cheers
Nick