This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Include <string.h> to dis-asm.h to get strchr declaration
- From: Nick Clifton <nickc at redhat dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>, Павел Крюков <kryukov at frtk dot ru>
- Cc: gdb-patches at sourceware dot org, binutils at sourceware dot org
- Date: Tue, 15 Jan 2019 14:01:32 +0000
- Subject: Re: [PATCH] Include <string.h> to dis-asm.h to get strchr declaration
- References: <CADip9ga4rPr6NiNzPBcEZCEwacMmGaNkvU-ZnmDw2L21qmXv2Q@mail.gmail.com> <1da4814ae31a668a24b80e162f5941a3@polymtl.ca>
Hi Simon,
>> Include <string.h> to dis-asm.h to get strchr declaration
>> #include <stdio.h>
>> +#include <string.h>
>> #include "bfd.h"
> I took the liberty of pushing this patch which touches code in include/, since it seemed obvious enough to me.
Do we need to worry about systems that have <strings.h> rather than <string.h> ?
There are various places in the binutils sources (eg binutils/sysdep.h) which
check for configure macros for these headers, which makes me wonder...
Cheers
Nick