This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 2/2] RISC-V: Merge ELF attribute for ld
- From: Jim Wilson <jimw at sifive dot com>
- To: Kito Cheng <kito dot cheng at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>, Palmer Dabbelt <palmer at sifive dot com>, RISC-V Patches <patches at groups dot riscv dot org>
- Date: Mon, 14 Jan 2019 18:00:26 -0800
- Subject: Re: [PATCH 2/2] RISC-V: Merge ELF attribute for ld
- References: <CA+yXCZB3hPiCwnADwy2FjTUE-_fQJ9MFrS9k5QpzTxiEzyLpzA@mail.gmail.com> <CAFyWVaaOyimjwtCoZSFWPP8rz_Z-krfw2FyefwTX_kL=6L_CUg@mail.gmail.com>
On Wed, Jan 9, 2019 at 12:28 PM Jim Wilson <jimw@sifive.com> wrote:
> On Wed, Jan 9, 2019 at 5:47 AM Kito Cheng <kito.cheng@gmail.com> wrote:
> > This is version 2 patch of implement the RISC-V ELF attribute merge.
This looks good. It fixes the testsuite failures I had with only the
other two patches applied.
I noticed one place in riscv_merge_non_std_and_sv_ext where you still
have a line that ends with an open paren, but that is a minor style
issue.
I found it interesting that now that we use standard numbering for
attributes and standard code for parsing them, we can't have a zero
value Tag_RISCV_unaligned_access attribute anymore, as the standard
code filters out attributes with default values. That looks OK
though, I don't think it will be a problem.
This is OK to go in once the other two patches are in.
Jim