This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: Add PT_GNU_PROPERTY to cover .note.gnu.property section


* H. J. Lu:

> diff --git a/ld/testsuite/ld-elf/pr23900-1b.d b/ld/testsuite/ld-elf/pr23900-1b.d
> new file mode 100644
> index 0000000000..e1555c29f6
> --- /dev/null
> +++ b/ld/testsuite/ld-elf/pr23900-1b.d
> @@ -0,0 +1,14 @@
> +#source: pr23900-1.s
> +#ld:
> +#readelf: -l --wide
> +#target: *-*-linux* *-*-gnu* *-*-nacl*
> +
> +#...
> +  GNU_PROPERTY .*
> +#...
> + +[0-9]+ +\.note\.gnu\.property 
> +#...
> + +[0-9]+ +\.note\.gnu\.property 
> +#...
> + +[0-9]+ +\.note\.gnu\.property 
> +#...

Sholdn't there be a test that checks that the segment alignment is as
expected?

What happened to the earlier concerns that the presence of
PT_GNU_PROPERTY will break some existing installations?

I would strongly recommended to try harder to get consensus here.  I do
not want to be a in a situation were we revise ABI again two years from
now.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]