This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Commit: Sync libiberty and add --no-recurse-limit option to binutils


On Mon, Dec 10, 2018 at 7:00 AM Nick Clifton <nickc@redhat.com> wrote:
>
> > Since this is apparently a real symbol from real code, can you find
> > out what the recursion limit would have to be to successfully demangle
> > it?
>
> Certainly.  2048 does the trick.
>
> What actually happened was that I ran the libiberty testsuite with v1 of
> the patch, and the 1024 limit worked.  But then when I changed the patch
> to move the recursion counters into the work structures, I forgot to retest
> the patch.  The problem was then that the recursion counter was now shared
> between multiple functions, and so the 1024 limit was not enough.  Since I
> only changed three functions I guessed that doubling the limit would be enough,
> and testing showed that this was true.
>
> So...
>
> Is this patch OK ?
>
> Cheers
>   Nick
>
> include/ChangeLog
> 2018-12-10  Nick Clifton  <nickc@redhat.com>
>
>         PR 88409
>         * demangle.h (DEMANGLE_RECURSION_LIMIT): Increase to 2048.

This is OK.

Thanks.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]