This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] multibyte encodings in strings


Hi Alan,

> Yeah, the output should be exactly "String1\nString2".  Anything else
> is broken.  I saw a blank line output before the expected output, and
> in one other instance:
> 
> in
> String1
> String2
> 
> git commit 71f5e3f7b624 obviously wasn't tested on a big-endian host,
> and the test fail message resulted in tcl errors.  This patch should
> fix the issues I found.
> 
> 	* strings.c (unget_part_char): New function.
> 	(print_strings): Use unget_part_char.  Formatting.
> 	* testsuite/binutils-all/strings.exp (test_multibyte): Don't
> 	use square brackets in fail message.  Expect "String1\nString2".

Thanks for fixing this. :-)

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]