This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fwd: [PATCH] elf: Report property change when merging properties


Hi H.J.

> Here is the updated patch to cut down noises.  Now it generates:
> 
> Mering program properties
> 
> Removed property 0xc0010000 to merge
> /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crt1.o (0x0) and
> /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crti.o (0x0)
> Removed property 0xc0000002 to merge
> /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crt1.o (0x3) and
> x.o (not found)
> Removed property 0xc0000000 to merge
> /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crt1.o (not
> found) and /usr/lib64/libc_nonshared.a(elf-init.oS) (0x0)
> Removed property 0xc0000001 to merge
> /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crt1.o (not
> found) and /usr/lib64/libc_nonshared.a(elf-init.oS) (0x0)

That is much nicer.

> OK for trunk?

>         * elf-properties.c (elf_find_and_remove_property): Add a
>         bfd_boolean argument to indicate if the property should be
>         removed.
>         (elf_merge_gnu_property_list): Updated.  Report
>         property change in linker map file.
>         (elf_get_gnu_property_section_size): Skip property_remove
>         properties.
>         (elf_write_gnu_properties): Likewise.
>         (_bfd_elf_link_setup_gnu_properties): Report property merge
>         in linker map file.  Pass abfd to elf_merge_gnu_property_list.
> 
> include/
> 
>         * bfdlink.h (bfd_link_info): Add has_map_file.
> 
> ld/
> 
>         * NEWS: Updated for property change report.
>         * ld.texi: Document property change report.
>         * ldmain.c (main): Set link_info.has_map_file to TRUE when
>         linker map file is used.
>         * testsuite/ld-x86-64/property-x86-ibt1a-x32.d: Check linker map
>         file.
>         * testsuite/ld-x86-64/property-x86-ibt1a.d: Likewise.
>         * testsuite/ld-x86-64/property-x86-ibt1a.map: New file.

Approved - please apply.

Cheers
  Nick



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]