This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][GAS][Arm] Skip Local BLX Thumb tests for arm-netbsdelf and arm-nto


Now with the patch...

On 06/12/18 09:51, Andre Vieira (lists) wrote:
> Hi,
> 
> Sorry for the delay. As I mentioned in
> https://sourceware.org/ml/binutils/2018-11/msg00253.html these targets
> can currently not determine whether the function called by BLX is either
> arm or thumb mode. So this feature will not (and has never) worked,
> skipping the relevant test.
> 
> Is this OK for trunk?
> 
> Cheers,
> Andre
> 
> gas/ChangeLog
> 2018-11-30  Andre Vieira  <andre.simoesdiasvieira@arm.com>
> 
>         * testsuite/gas/arm/blx-local-thumb.d: Skip arm-nto and
> arm-netbsdelf.
> 

>From b53e1e712c7fb7076901fafeb58ab136914f4573 Mon Sep 17 00:00:00 2001
From: Andre Vieira <andre.simoesdiasvieira@arm.com>
Date: Fri, 30 Nov 2018 14:40:24 +0000
Subject: [PATCH] [GAS][Arm] Skip Local BLX Thumb test for arm-netbsdelf and
 arm-nto

These targets can currently not determine the target of BLX to be in the same
mode as the source, so this feature will not work for them.  Skipping relevant
test.
---
 gas/testsuite/gas/arm/blx-local-thumb.d | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gas/testsuite/gas/arm/blx-local-thumb.d b/gas/testsuite/gas/arm/blx-local-thumb.d
index a0a2c048f0b5ddf614bf677953875dfe38dbe5e4..18af8e6d5db0b78e3b1589481b542735f11dd878 100644
--- a/gas/testsuite/gas/arm/blx-local-thumb.d
+++ b/gas/testsuite/gas/arm/blx-local-thumb.d
@@ -1,6 +1,6 @@
 #name: Local BLX instructions in Thumb mode.
 #objdump: -drw --prefix-addresses --show-raw-insn
-#skip: *-*-pe *-*-wince
+#skip: *-*-pe *-*-wince *-*nto* *-*netbsdelf*
 #as:
 #warning_output: blx-local-thumb.l
 
-- 
1.9.1


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]