This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v4]
- From: Pedro Alves <palves at redhat dot com>
- To: Nick Clifton <nickc at redhat dot com>, Ian Lance Taylor <iant at google dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>, matz at gcc dot gnu dot org, sgayou at redhat dot com, Tom Tromey <tom at tromey dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Binutils <binutils at sourceware dot org>, Jason Merrill <jason at redhat dot com>
- Date: Tue, 4 Dec 2018 15:02:44 +0000
- Subject: Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v4]
- References: <87muprdko7.fsf@redhat.com> <20181130084211.GX12380@tucnak> <173817ca-0aa0-e1a2-6725-37e079ead545@redhat.com> <m3woousm8n.fsf@pepe.airs.com> <20181130140330.GA12380@tucnak> <fa1abe9c-7545-6a48-cbf0-97b993345523@redhat.com> <CAFiYyc1gTSXgSiJSFKEWaE0UTGbi45-mWHKJnUb4Wvjp86bbFQ@mail.gmail.com> <460cb971-0e21-1e3e-4920-8b3ee7290cf7@redhat.com> <CAKOQZ8zspME4gzoRw4xgFcShoqeUfp_e=Og=4S-yKn4EehokeA@mail.gmail.com> <736e8303-b724-f96d-54f5-46bff99fa34d@redhat.com>
On 12/04/2018 01:59 PM, Nick Clifton wrote:
> OK then, here is a fourth revision of the patch.
The issue pointed out by
https://gcc.gnu.org/ml/gcc-patches/2018-11/msg02592.html
is still present in this version.
Also, noticed a typo here:
> +/* If DMGL_NO_RECURE_LIMIT is not enabled, then this is the value used as
Typo: "RECURE"
> + the maximum depth of recursion allowed. It should be enough for any
> + real-world mangled name. */
> +#define DEMANGLE_RECURSION_LIMIT 1024
> +
Thanks,
Pedro Alves