This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gold: Provide more failed archive member info in error message
- From: Cary Coutant <ccoutant at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 4 Dec 2018 00:00:38 -0800
- Subject: Re: [PATCH] gold: Provide more failed archive member info in error message
- References: <20181202144457.9193-1-hjl.tools@gmail.com>
> + bool plugin_failed = false;
>
> if (is_elf_object(input_file, memoff, &ehdr, &read_size))
> {
> @@ -716,12 +717,20 @@ Archive::get_elf_object_for_member(off_t off, bool* punconfigured)
> delete obj;
> return plugin_obj;
> }
> +
> + plugin_failed = true;
An unclaimed file is not a plugin "failure". I'd prefer to name this
variable "unclaimed".
-cary