This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] opcodes/riscv: Hide '.L0 ' fake symbols


On Dez 03 2018, Andrew Burgess <andrew.burgess@embecosm.com> wrote:

> diff --git a/opcodes/disassemble.c b/opcodes/disassemble.c
> index 750d76ad865..36617c4977d 100644
> --- a/opcodes/disassemble.c
> +++ b/opcodes/disassemble.c
> @@ -649,6 +649,11 @@ disassemble_init_for_target (struct disassemble_info * info)
>  #ifdef ARCH_powerpc
>      case bfd_arch_powerpc:
>  #endif
> +#ifdef ARCH_riscv
> +    case bfd_arch_riscv:
> +      info->symbol_is_valid = riscv_symbol_is_valid;
> +      break;
> +#endif
>  #ifdef ARCH_rs6000
>      case bfd_arch_rs6000:
>  #endif

You are adding code and a break in the middle of two unreleated cases.
That will break the powerpc case.  Moreover, there is already another
use of case bfd_arch_riscv, so this cannot even compile.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]