This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] elf: Report property change when merging properties

From: Nick Clifton <nickc at redhat dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>, Alan Modra <amodra at gmail dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Tue, 27 Nov 2018 12:35:29 +0000
Subject: Re: [PATCH] elf: Report property change when merging properties
References: <20181122184835.25437-1-hjl.tools@gmail.com> <20181126001549.GS21617@bubble.grove.modra.org> <CAMe9rOq-x82Eo5J63WGkGpH6ots_6bQvv3U4e5L1Os5+uydyPg@mail.gmail.com>

Hi Guys,

>>> Merging property 0xc0000002 in foo.o (0x1) and bar.o (None): removed
>>
>> To me this is a confusing message.  How about simply saying "Removed
>> property 0xc0000002 in foo.o (0x1)", and similarly for the other

> This misses the crucial info that property 0xc0000002 is removed due to
> bar.o (None).

Indeed - this was my motivation for requesting the patch in the first place.

How about rewording the message as:

  Property 0xc00000002 (0x1) found in foo.o but removed from final link because it is not found in bar.o

A little bit more wordy perhaps, but I think that it explains what is going
on in clearer language.

Cheers
  Nick

Follow-Ups:
- Re: [PATCH] elf: Report property change when merging properties
  - From: H.J. Lu

References:
- [PATCH] elf: Report property change when merging properties
  - From: H.J. Lu
- Re: [PATCH] elf: Report property change when merging properties
  - From: Alan Modra
- Re: [PATCH] elf: Report property change when merging properties
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]