This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] elf: Report property change when merging properties

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: Alan Modra <amodra at gmail dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Mon, 26 Nov 2018 05:05:50 -0800
Subject: Re: [PATCH] elf: Report property change when merging properties
References: <20181122184835.25437-1-hjl.tools@gmail.com> <20181126001549.GS21617@bubble.grove.modra.org>

On Sun, Nov 25, 2018 at 4:15 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Thu, Nov 22, 2018 at 10:48:35AM -0800, H.J. Lu wrote:
> > With merging properties, report property change in linker map file, like
> >
> > Merging property 0xc0000002 in foo.o (0x1) and bar.o (None): removed
>
> To me this is a confusing message.  How about simply saying "Removed
> property 0xc0000002 in foo.o (0x1)", and similarly for the other
> messages where properties are removed.  If ld is removing them then it
> isn't merging them.

This misses the crucial info that property 0xc0000002 is removed due to
bar.o (None).

-- 
H.J.

Follow-Ups:
- Re: [PATCH] elf: Report property change when merging properties
  - From: Nick Clifton

References:
- [PATCH] elf: Report property change when merging properties
  - From: H.J. Lu
- Re: [PATCH] elf: Report property change when merging properties
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]