This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] objdump: allow to display instructions only for given label
- From: Masatake YAMATO <yamato at redhat dot com>
- To: nickc at redhat dot com
- Cc: binutils at sourceware dot org
- Date: Thu, 08 Nov 2018 10:16:43 +0900 (JST)
- Subject: Re: [PATCH] objdump: allow to display instructions only for given label
- References: <20181022194026.7294-1-yamato@redhat.com> <a9b02229-ebeb-e7b2-b48d-28b4686ee128@redhat.com>
Hi,
> Hi Masatake-san,
>
>> * objdump.c (long_options): make --disassemble option take
>> option argument.
>> (usage): Add description for `label' option argument
>> for the --disassemble option.
>> (label): New file private variable.
>> (struct objdump_disasm_info): New field `label'.
>> (disassemble_section): Introduce `do_print' local variable
>> to control whether objdump displays the result of disassembling
>> for a lable or not.
>> (main): Set `label' file private variable if the option argument
>> for the --disassemble option is given.
>>
>> * doc/binutils.texi (objdump): Add description for the option
>> argument.
>
> Thank you for submitting this patch. I have applied it along with
> a couple of minor additions. Specifically I added an entry in the
> binutils/NEWS file mentioning this new feature, and I added a test
> to the binutils testsuite to check that the feature works.
Sorry for taking your time.
If I have a chance to send a patch, I will write a NEWS entry and a
test case. Thank you.
Masatake YAMATO
>
> Cheers
> Nick
>