This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/6] mach-o: Don't split version into a few fields
- From: tgingold at free dot fr
- To: Roman Bolshakov <r dot bolshakov at yadro dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 6 Nov 2018 15:25:13 +0100 (CET)
- Subject: Re: [PATCH 1/6] mach-o: Don't split version into a few fields
Hello,
I am ok with your whole patchset, but:
> +static void
> +printf_version (uint32_t version) {
> + uint32_t maj, min, upd;
> + maj = (version >> 16) & 0xffff;
> + min = (version >> 8) & 0xff;
> + upd = version & 0xff;
> + printf ("%u.%u.%u", maj, min, upd);
> +}
this doesn't follow the GNU code style. The '{' must be on a new line.
I haven't upgraded to latest Darwin, so I haven't checked the code.
Thanks,
Tristan.