This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GAS][ARM] Fix ARMv8.1 AdvSIMD testism
- From: "Andre Vieira (lists)" <Andre dot SimoesDiasVieira at arm dot com>
- To: Thomas Preudhomme <thomas dot preudhomme at linaro dot org>
- Cc: binutils at sourceware dot org, Nick Clifton <nickc at redhat dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Date: Tue, 30 Oct 2018 11:18:52 +0000
- Subject: Re: [GAS][ARM] Fix ARMv8.1 AdvSIMD testism
- References: <5BC9F164.1080509@arm.com> <CAKnkMGuYg9xCSaRW339x1TE1eBgJN1C2BhwN3ZqPToEDsK745w@mail.gmail.com>
On 26/10/18 11:27, Thomas Preudhomme wrote:
> Hi Andre,
>
> On Fri, 19 Oct 2018 at 16:00, Andre Vieira (lists)
> <Andre.SimoesDiasVieira@arm.com> wrote:
>>
>>
>> Hi,
>>
>> This patch fixes a testism.
>> This test never used to test the output of objdump as the old 'error-output'
>> check would exit after verifying the output in stdout and stderr from the
>> assembler. Given the use of warning_output now, the objdump runs and
>> expects
>> its output to be verified. Assuming the correct disassembly of these
>> instructions is tested elsewhere given we never tested them here, this patch
>> removes the objdump run.
>
> It is indeed in gas/testsuite/gas/arm/armv8-a+rdma.d
>
> Patch therefore looks good to me. I'm not a maintainer though so
> you'll need someone else to approve.
>
> Best regards,
>
> Thomas
>>
>> Is this OK for trunk?
>>
>> gas/ChangeLog
>>
>> 2018-10-19 Andre Vieira <andre.simoesdiasvieira@arm.com>
>>
>> * testsuite/gas/arm/armv8-a+rdma-warning.d: Remove
>> objdump execution.
Ping.