This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GAS][ARM] Fix testism for bl local v4t test
- From: Thomas Preudhomme <thomas dot preudhomme at linaro dot org>
- To: Andre dot SimoesDiasVieira at arm dot com
- Cc: binutils at sourceware dot org
- Date: Fri, 26 Oct 2018 11:38:38 +0100
- Subject: Re: [GAS][ARM] Fix testism for bl local v4t test
- References: <5BC9F15F.7020403@arm.com>
Hi Andre,
On Fri, 19 Oct 2018 at 15:59, Andre Vieira (lists)
<Andre.SimoesDiasVieira@arm.com> wrote:
>
> Hi,
>
> This patch fixes a testism.
> I believe this test was never really intended to test for this error
> message and
> '# stderr' never actually checked it. This warning is tested elsewhere
> and to my
> understanding it would have not made any sense here either.
>
> I did some archaeological digging and found that the original patch that
> was reviewed on the ml contained a blx-thumb-local.{d,s,l}.
> See https://sourceware.org/ml/binutils/2009-03/msg00511.html
> The commit itself was missing the .s and .d files, I suspect these fell
> through the 'svn add' crack and they help explain why there is a
> blx-thumb-local.l to begin with.
> I re-added them in this patch and updated due to bitrot.
>
> Is this OK for trunk?
The commit 2ac93be706418f3b2aebeb22159a328023faed52 removed support
for arm aout and coff targets, you can see that it simplifies the very
same skip line to skipping only wince and pe arm targets and would
therefore suggest to adapt the test you add to do the same.
Beyond that, there is mention of relocation for foo so I'd suggest
adding a readelf -r action and check for those relocation.
Best regards,
Thomas
>
> gas/ChangeLog
>
> 2018-10-19 Andre Vieira <andre.simoesdiasvieira@arm.com>
>
> * testsuite/gas/arm/bl-local-v4t.d: Remove
> warning check.
> * testsuite/gas/arm/blx-local-thumb.s: New.
> * testsuite/gas/arm/blx-local-thumb.d: New.