This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][Binutils][Arm] Fix disassembler crashing on -b binary when thumb file and thumb not forced.
- From: Nick Clifton <nickc at redhat dot com>
- To: Tamar Christina <tamar dot christina at arm dot com>, binutils at sourceware dot org
- Cc: nd at arm dot com, Richard dot Earnshaw at arm dot com, ramana dot radhakrishnan at arm dot com
- Date: Thu, 18 Oct 2018 17:18:03 +0100
- Subject: Re: [PATCH][Binutils][Arm] Fix disassembler crashing on -b binary when thumb file and thumb not forced.
- References: <20181017161810.GA16924@arm.com>
Hi Tamar,
> gas/ChangeLog:
> 2018-10-17 Tamar Christina <tamar.christina@arm.com>
>
> * testsuite/gas/arm/undefined-insn-arm.d: New test.
> * testsuite/gas/arm/undefined-insn-thumb.d: New test.
> * testsuite/gas/arm/undefined-insn.s: New test.
>
> opcodes/ChangeLog:
> 2018-10-17 Tamar Christina <tamar.christina@arm.com>
>
> * arm-dis.c (UNKNOWN_INSTRUCTION_32BIT): Format specifier for arm mode.
> (UNKNOWN_INSTRUCTION_16BIT): Format specifier for thumb mode.
> (print_insn_arm, print_insn_thumb16, print_insn_thumb32): Use them.
Approved - please apply.
Cheers
Nick
PS. Thank you for getting rid of some aborts. Personally, I think that
they are a bad thing to have in a library...