This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] elf32-nds32: Remove elf32_nds32_allocate_dynrelocs
- From: Kuan-Lin Chen <kuanlinchentw at gmail dot com>
- To: simon dot marchi at ericsson dot com, "binutils at sourceware dot org Development" <binutils at sourceware dot org>
- Date: Wed, 26 Sep 2018 10:54:05 +0800
- Subject: Re: [PATCH] elf32-nds32: Remove elf32_nds32_allocate_dynrelocs
- References: <20180920181620.3046-1-simon.marchi@ericsson.com>
OK. Thanks.
Simon Marchi <simon.marchi@ericsson.com> 於 2018年9月21日 週五 上午2:17寫道:
>
> It is unused, removing it fixes this error when building with clang:
>
> /home/emaisin/src/binutils-gdb/bfd/elf32-nds32.c:3172:1: error: unused function 'elf32_nds32_allocate_dynrelocs' [-Werror,-Wunused-function]
> elf32_nds32_allocate_dynrelocs (struct bfd_link_info *info, asection *sreloc,
> ^
> 1 error generated.
>
> gcc only reports the error if you remove "inline". I don't know if this
> is actually a mistake and it should actually be used though.
>
> gdb/ChangeLog:
>
> * elf32-nds32.c (elf32_nds32_allocate_dynrelocs): Remove.
> ---
> bfd/elf32-nds32.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/bfd/elf32-nds32.c b/bfd/elf32-nds32.c
> index 6215f288009..a4f5ca4dc33 100644
> --- a/bfd/elf32-nds32.c
> +++ b/bfd/elf32-nds32.c
> @@ -3165,19 +3165,6 @@ static const struct nds32_reloc_map_entry nds32_reloc_map[] =
>
> /* Patch tag. */
>
> -/* Reserve space for COUNT dynamic relocations in relocation selection
> - SRELOC. */
> -
> -static inline void
> -elf32_nds32_allocate_dynrelocs (struct bfd_link_info *info, asection *sreloc,
> - bfd_size_type count)
> -{
> - BFD_ASSERT (elf_hash_table (info)->dynamic_sections_created);
> - if (sreloc == NULL)
> - abort ();
> - sreloc->size += sizeof (Elf32_External_Rela) * count;
> -}
> -
> static reloc_howto_type *
> bfd_elf32_bfd_reloc_name_lookup (bfd *abfd ATTRIBUTE_UNUSED,
> const char *r_name)
> --
> 2.19.0
>
--
Best regards,
Kuan-Lin Chen.
kuanlinchentw@gmail.com