This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[patch, testsuite] skip broken test on Windows
- From: Sandra Loosemore <sandra at codesourcery dot com>
- To: <binutils at sourceware dot org>
- Cc: "nickc at redhat dot com" <nickc at redhat dot com>
- Date: Mon, 24 Sep 2018 14:55:39 -0600
- Subject: [patch, testsuite] skip broken test on Windows
This patch is a followup to PR23153, in which it was reported that gas's
inode comparison test for identical input and output files doesn't work
on MinGW hosts, so it was disabled. Now the test case that is supposed
to verify that a diagnostic is issued not only FAILs, it also ends up
overwriting its input file -- which is used by another test too, so that
FAILs as well. It seems like the solution is "don't do that".
OK to commit?
-Sandra
commit 16c0f75db55f5ec5fb787122ac3be66872040a58
Author: Sandra Loosemore <sandra@codesourcery.com>
Date: Mon Sep 24 13:36:28 2018 -0700
Skip broken assembler test on Windows host.
2018-09-24 Sandra Loosemore <sandra@codesourcery.com>
gas/
* testsuite/gas/all/gas.exp: Skip "Output file must be distinct
from input" test on Windows host.
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 72857e1..a143cc8 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2018-09-24 Sandra Loosemore <sandra@codesourcery.com>
+
+ * testsuite/gas/all/gas.exp: Skip "Output file must be distinct
+ from input" test on Windows host.
+
2018-09-21 H.J. Lu <hongjiu.lu@intel.com>
PR gas/23691
diff --git a/gas/testsuite/gas/all/gas.exp b/gas/testsuite/gas/all/gas.exp
index 5335c89..c1237f9 100644
--- a/gas/testsuite/gas/all/gas.exp
+++ b/gas/testsuite/gas/all/gas.exp
@@ -73,7 +73,11 @@ if { ![istarget alpha*-*-*vms*]
gas_test_error "equiv1.s" "" ".equiv for symbol already set to another one"
gas_test_error "equiv2.s" "" ".equiv for symbol already set to an expression"
-gas_test_error "none.s" "-o $srcdir/$subdir/none.s" "Output file must be distinct from input"
+# The inode comparison used to detect identical input and output files
+# doesn't work on non-Posix hosts.
+if { ![ishost "*-*-mingw*"] } then {
+ gas_test_error "none.s" "-o $srcdir/$subdir/none.s" "Output file must be distinct from input"
+}
# .equ works differently on some targets.
case $target_triplet in {