Re: [PATCH] sparc/leon: add support for partial write psr instruction

[Daniel Cederman <cederman at gaisler dot com>]

Hi Rainer,

> just a nit: why do you place this sparcv8 test somewhere randomly in the
> middle of sparcv9 tests sorted by increasingly newer ISA extensions?

It ended up there when I was trying out the test environment and I 
forgot to move it. I will place it together with the v8 tests after 
'run_dump_test "save-args"' instead.

> It may also be that you don't need the set_tests_arch "leon"

Yes, that seems to be the case. I will remove that line. Thank you for 
your comments!

Best regards,

Daniel Cederman
Cobham Gaisler

On 2018-08-21 10:32, Rainer Orth wrote:
> Hi Daniel,
>
> > diff --git a/gas/testsuite/gas/sparc/sparc.exp b/gas/testsuite/gas/sparc/sparc.exp
> > index dcfec404d16..b0bcc65c706 100644
> > --- a/gas/testsuite/gas/sparc/sparc.exp
> > +++ b/gas/testsuite/gas/sparc/sparc.exp
> > @@ -86,6 +86,9 @@ if [istarget sparc*-*-*] {
> >   	run_dump_test "sparc5vis4"
> >   	run_dump_test "xcrypto"
> >   
> > +	set_tests_arch "leon"
> > +	run_dump_test "leon"
> > +
> >   	set_tests_arch "v9m8"
> >   	run_dump_test "fpcmpshl"
> >   	run_dump_test "ldm-stm"
>
>
> It may also be that you don't need the set_tests_arch "leon": this is
> only meant for isa (extensions) not enabled by default.
>
> 	Rainer