This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] sparc/leon: add support for partial write psr instruction
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Daniel Cederman <cederman at gaisler dot com>
- Cc: binutils at sourceware dot org, maberg at gaisler dot com
- Date: Tue, 21 Aug 2018 10:32:06 +0200
- Subject: Re: [PATCH] sparc/leon: add support for partial write psr instruction
- References: <20180821082122.1258-1-cederman@gaisler.com>
Hi Daniel,
> diff --git a/gas/testsuite/gas/sparc/sparc.exp b/gas/testsuite/gas/sparc/sparc.exp
> index dcfec404d16..b0bcc65c706 100644
> --- a/gas/testsuite/gas/sparc/sparc.exp
> +++ b/gas/testsuite/gas/sparc/sparc.exp
> @@ -86,6 +86,9 @@ if [istarget sparc*-*-*] {
> run_dump_test "sparc5vis4"
> run_dump_test "xcrypto"
>
> + set_tests_arch "leon"
> + run_dump_test "leon"
> +
> set_tests_arch "v9m8"
> run_dump_test "fpcmpshl"
> run_dump_test "ldm-stm"
just a nit: why do you place this sparcv8 test somewhere randomly in the
middle of sparcv9 tests sorted by increasingly newer ISA extensions?
It may also be that you don't need the set_tests_arch "leon": this is
only meant for isa (extensions) not enabled by default.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University