This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/2 V2] gas/as.c: print input and output filenames when error
- From: "Jan Beulich" <JBeulich at suse dot com>
- To: "Robert Yang" <liezhi dot yang at windriver dot com>
- Cc: "Nick Clifton" <nickc at redhat dot com>,<binutils at sourceware dot org>
- Date: Thu, 09 Aug 2018 04:25:40 -0600
- Subject: Re: [PATCH 1/2 V2] gas/as.c: print input and output filenames when error
- References: <1533810071-102709-1-git-send-email-liezhi.yang@windriver.com>
>>> On 09.08.18 at 12:21, <liezhi.yang@windriver.com> wrote:
> --- a/gas/as.c
> +++ b/gas/as.c
> @@ -1259,8 +1259,10 @@ main (int argc, char ** argv)
> if (sib.st_ino == sob.st_ino && sib.st_ino != 0)
> {
> /* Don't let as_fatal remove the output file! */
> + saved_out_file_name = xstrdup (out_file_name);
Actually - why xstrdup()? And why to a global variable?
Jan