This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH 1/5] [ARC] Update handling AUX-registers.
- From: Claudiu Zissulescu <claziss at synopsys dot com>
- To: Nick Clifton <nickc at redhat dot com>, Claudiu Zissulescu <claziss at gmail dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: "Francois dot Bedard at synopsys dot com" <Francois dot Bedard at synopsys dot com>
- Date: Thu, 2 Aug 2018 13:06:36 +0000
- Subject: RE: [PATCH 1/5] [ARC] Update handling AUX-registers.
- References: <20180724142641.2678-1-claziss@gmail.com> <0bac3455-7886-ae89-1ca3-5cd97b6b7081@redhat.com>
Hi Nick,
> If you were the maintainer for the ARC target you could self-approve these
> patches you know...
I am not, but I am interested :) in the if part...
>
> > + /* For compatibility reasons, an aux register can
> > + be spelled with upper or lower case
> > + letters. */
> > + tmpp = strdup (p);
> > + for (pp = tmpp; *pp; ++pp) *pp = TOLOWER (*pp);
> > +
> > + auxr = hash_find (arc_aux_hash, tmpp);
>
> Memory leak - you do not free tmpp. Trivial I know, but I have started
> having to fix things like this in Fedora land.
Many thanks, I will resubmit the patch with the fix. I also need to recheck the ARC port for memory leaks.
Thank you,
Claudiu