This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: ld testsuite use of notarget
- From: "Maciej W. Rozycki" <macro at linux-mips dot org>
- To: Alan Modra <amodra at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 1 Aug 2018 13:56:39 +0100 (BST)
- Subject: Re: ld testsuite use of notarget
- References: <20180710144144.GH3373@bubble.grove.modra.org> <alpine.DEB.2.00.1807101546210.30992@tp.orcam.me.uk> <20180711025043.GJ3373@bubble.grove.modra.org>
On Wed, 11 Jul 2018, Alan Modra wrote:
> > This is not a bug, we do not support the GNU hash for the MIPS target
> > due to psABI restrictions on dynsym table ordering. So I'd rather left
> > it with #notarget for an accurate UNSUPPORTED result.
>
> I think it is better as an xfail. xfail doesn't necessarily mean you
> have a bug, just that the test is expected to fail. Suppose in some
> future patch someone enabled GNU hash for mips targets. Then an XPASS
> on this test indicates a bug! (My point 3 in why notarget is a bad
> idea.)
Fair enough.
> > I think this test case is broken, I fail to see from PR ld/20022 why it
> > insists on using `.text' for relocated data rather than `.data' (and then
> > it would work for all targets). There's nothing specific to `.text' here
> > AFAICT.
>
> True, except the test uses -e _start and it's unusual for an entry
> point to be in .data. I'll see how that goes.
FWIW I use `-e 0' when an entry point is required in a test case to keep
LD quiet and the actual value does not matter for the scenario covered.
Maciej