This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/5] [ARC] Update merging attributes.

From: Nick Clifton <nickc at redhat dot com>
To: Claudiu Zissulescu <claziss at gmail dot com>, binutils at sourceware dot org
Cc: fbedard at synopsys dot com, claziss at synopsys dot com
Date: Tue, 31 Jul 2018 17:05:18 +0100
Subject: Re: [PATCH 3/5] [ARC] Update merging attributes.
References: <20180724142641.2678-1-claziss@gmail.com> <20180724142641.2678-3-claziss@gmail.com>

Hi Claudiu,

> bfd/
> 2017-09-19  Claudiu Zissulescu <claziss@synopsys.com>
> 
> 	* elf32-arc.c (arc_elf_merge_attributes): Fix merge attributes.
> 
> ld/
> 2017-09-19  Claudiu Zissulescu <claziss@synopsys.com>
> 
> 	* testsuite/ld-arc/attr-merge-6.d: New file.
> 	* testsuite/ld-arc/attr-merge-6a.s: Likewise.
> 	* testsuite/ld-arc/attr-merge-6b.s: Likewise.
> 	* testsuite/ld-arc/attr-merge-6bis.d: Likewise.


>  	case Tag_ARC_CPU_name:
> +	  if (!out_attr[i].s && in_attr[i].s)
> +	    out_attr[i].s = _bfd_elf_attr_strdup (obfd, in_attr[i].s);
>  	  break;

What should happen if out_attr[i].s and in_attr[i].s are both defined, and different ?

Cheers
  Nick

References:
- [PATCH 1/5] [ARC] Update handling AUX-registers.
  - From: Claudiu Zissulescu
- [PATCH 3/5] [ARC] Update merging attributes.
  - From: Claudiu Zissulescu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]