This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: don't wrongly scale non-8-bit displacements
>>> On 30.07.18 at 18:38, <hjl.tools@gmail.com> wrote:
> On Mon, Jul 30, 2018 at 9:30 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 30.07.18 at 17:32, <hjl.tools@gmail.com> wrote:
>>> You should have added "PR gas/23465" to commit log so that
>>>
>>> https://sourceware.org/bugzilla/show_bug.cgi?id=23465
>>
>> Hmm, it's there in my local git tree, and it's also there according to
>>
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=629cf
> af1b0fbb32a985607c774bd8e7870b9fa94
>> Did I typo it somehow, albeit I'm sure I've simple copy-n-pasted
>> what you wrote in your mail?
>>
>
> "PR gas/23465" must be in COMMIT message like:
>
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1286ab788188bb8f0
> b0da2a3def4641fb3817f10
Hmm, interesting. Putting the ChangeLog addition also in the commit
message is bad practice as I recall, now that the tree is a git one. I'll
try to remember to keep (just) the PR line for the 2.31.1 commit.
Jan