This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] x86: Initialize broadcast_op.bytes to 0


On Thu, Jul 26, 2018 at 8:02 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> Also, wouldn't you better clear ->bytes again in case the function later
>> returns an error, leading to the next template to be looked at?
>
> Good point.  I will take a look.
>

This is what I checked in.


-- 
H.J.
From 1f75763aa1bfe2f998f4347f0de436092a126980 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 26 Jul 2018 08:49:12 -0700
Subject: [PATCH] x86: Initialize broadcast_op.bytes to 0

	* config/tc-i386.c (check_VecOperations): Initialize
	broadcast_op.bytes to 0.
---
 gas/ChangeLog        | 5 +++++
 gas/config/tc-i386.c | 1 +
 2 files changed, 6 insertions(+)

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 582a12d0ee..e8c500a2c0 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2018-07-26  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* config/tc-i386.c (check_VecOperations): Initialize
+	broadcast_op.bytes to 0.
+
 2018-07-26  Alex Chadwick  <Alex.Chadwick@cl.cam.ac.uk>
 
 	* config/tc-ppc.c (md_show_usage): Add -mgekko and -mbroadway.
diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index 3f8bd93224..9e9c676580 100644
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -8634,6 +8634,7 @@ check_VecOperations (char *op_string, char *op_end)
 
 	      broadcast_op.type = bcst_type;
 	      broadcast_op.operand = this_operand;
+	      broadcast_op.bytes = 0;
 	      i.broadcast = &broadcast_op;
 	    }
 	  /* Check masking operation.  */
-- 
2.17.1


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]