This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/5] xtensa: fix relaxation of undefined weak references in shared objects
- From: "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>
- Cc: binutils at sourceware dot org, Eric Tsai <erictsai at cadence dot com>, linux-xtensa at linux-xtensa dot org
- Date: Mon, 23 Jul 2018 11:58:16 -0700
- Subject: Re: [PATCH 1/5] xtensa: fix relaxation of undefined weak references in shared objects
- References: <20180723181030.11632-1-jcmvbkbc@gmail.com> <20180723181030.11632-2-jcmvbkbc@gmail.com>
On Mon, Jul 23, 2018 at 11:10 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> The change c451bb34ae8b ("xtensa: don't emit dynamic relocation for weak
> undefined symbol") didn't properly handled shrinking of relocation
> sections due to coalescing of references to a dynamic undefined weak
> symbol in a shared object, which resulted in the following assertion
> failure in ld when linking uClibc-ng libthread_db for xtensa:
>
> BFD (GNU Binutils) 2.31 internal error, aborting at elf32-xtensa.c:3269
> in elf_xtensa_finish_dynamic_sections
>
> Shrink dynamic relocations section for dynamic undefined weak symbols
> when linking a shared object.
>
> bfd/
> 2018-07-23 Max Filippov <jcmvbkbc@gmail.com>
>
> * elf32-xtensa.c (shrink_dynamic_reloc_sections): Shrink dynamic
> relocations section for dynamic undefined weak symbols when
> linking a shared object.
> ---
Approved.