This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 2/2] S/390: Improve partial relro support for 64 bit
Hi Andreas,
> ld/ChangeLog:
>
> 2018-07-13 Andreas Krebbel <krebbel@linux.ibm.com>
>
> * emulparams/elf64_s390.sh: Define GENERATE_RELRO_SCRIPT and
> SEPARATE_GOTPLT.
> * testsuite/ld-s390/gotreloc_64-relro-1.dd: New test.
> * testsuite/ld-s390/gotreloc_64-norelro-1.dd: Renamed from ...
> * testsuite/ld-s390/gotreloc_64-1.dd: ... this.
> * testsuite/ld-s390/s390.exp: Split the GOT testcase into two.
>
> bfd/ChangeLog:
>
> 2018-07-13 Andreas Krebbel <krebbel@linux.ibm.com>
>
> * elf-s390-common.c (s390_gotplt_after_got_p): New function.
> (s390_got_pointer): New function.
> (s390_got_offset): New function.
> (s390_gotplt_offset): New function.
> * elf64-s390.c (allocate_dynrelocs): Adjust comment.
> (elf_s390_size_dynamic_sections): Move space for magic GOT entries
> from .got.plt to .got if necessary and pick the right location for
> _GLOBAL_OFFSET_TABLE_.
> (elf_s390_relocate_section): Use the wrapper functions from
> elf-s390-common.c to deal with both possible layouts (either .got
> or .got.plt first).
> (elf_s390_finish_dynamic_sections): Likewise.
> (elf_s390_finish_dynamic_symbol): Make the location of the GOT
> magic entries conditional.
I assume that you are planning to commit this patch after the [1/2] patch
goes in. But just in case you were waiting for approval - not that you
need it, you can self-approve s390 changes - then patch approved, please
commit.
Cheers
Nick