This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] BFD/XCOFF: Fix storage class setting for weak defined symbols
- From: Alan Modra <amodra at gmail dot com>
- To: "Maciej W. Rozycki" <macro at mips dot com>
- Cc: Richard Sandiford <rdsandiford at googlemail dot com>, binutils at sourceware dot org
- Date: Wed, 18 Jul 2018 16:30:27 +0930
- Subject: Re: [PATCH] BFD/XCOFF: Fix storage class setting for weak defined symbols
- References: <alpine.DEB.2.00.1807160127000.30992@tp.orcam.me.uk>
On Mon, Jul 16, 2018 at 06:40:35AM +0100, Maciej W. Rozycki wrote:
> --- binutils.orig/bfd/xcofflink.c 2018-07-13 21:45:54.000000000 +0100
> +++ binutils/bfd/xcofflink.c 2018-07-13 21:49:54.561733638 +0100
> @@ -5592,7 +5592,7 @@ xcoff_write_global_symbol (struct bfd_ha
> BFD_ASSERT (bfd_is_abs_section (h->root.u.def.section));
> isym.n_value = h->root.u.def.value;
> isym.n_scnum = N_UNDEF;
> - if (h->root.type == bfd_link_hash_undefweak
> + if (h->root.type == bfd_link_hash_defweak
> && C_WEAKEXT == C_AIX_WEAKEXT)
> isym.n_sclass = C_WEAKEXT;
> else
There's another instance of the same error 66 lines after this one.
I think both count as obvious fixes.
--
Alan Modra
Australia Development Lab, IBM