This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] bfd: fix elflink.c build

From: "Jan Beulich" <JBeulich at suse dot com>
To: "Alan Modra" <amodra at gmail dot com>
Cc: <binutils at sourceware dot org>
Date: Tue, 10 Jul 2018 08:50:26 -0600
Subject: Re: [PATCH] bfd: fix elflink.c build
References: <5B44B54F02000078001D2ABA@prv1-mh.provo.novell.com> <20180710143534.GG3373@bubble.grove.modra.org>

>>> On 10.07.18 at 16:35, <amodra@gmail.com> wrote:
> On Tue, Jul 10, 2018 at 07:31:59AM -0600, Jan Beulich wrote:
>> Commit b8a6ced796 ("Correct removal of .gnu.attributes") introduced a
>> "remove" local variable, but "remove" is an identifier older stdio.h
>> supplies, and at least some compiler versions complain about the
>> shadowing of the name.
>> 
>> bfd/
>> 2018-07-10  Jan Beulich  <jbeulich@suse.com>
>> 
>> 	* elflink.c (bfd_elf_final_link): Rename "remove" to "rm".
> 
> Thanks, but Maciej has already posted a patch.
> https://sourceware.org/ml/binutils/2018-07/msg00121.html 

Oh, okay - I had noticed only the breakage, not the patch, and
I was sort of assuming that a simple fix like this would have gone
in pretty quickly.

Jan

References:
- [PATCH] bfd: fix elflink.c build
  - From: Jan Beulich
- Re: [PATCH] bfd: fix elflink.c build
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]