This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Error for mismatched powerpc ABI tags
- From: Nick Clifton <nickc at redhat dot com>
- To: Alan Modra <amodra at gmail dot com>, binutils at sourceware dot org
- Date: Thu, 5 Jul 2018 11:02:09 +0100
- Subject: Re: Error for mismatched powerpc ABI tags
- References: <20180705005036.GC3404@bubble.grove.modra.org>
Hi Alan,
> And report the two input files that are incompatible rather than
> reporting that an input file is incompatible with the output. I think
> that's rather more useful. Saying that a file is incompatible with
> the output leaves a user wondering why the output file is that way,
> and those users who eventually figure out it has something to do with
> input files before the one reported don't know which input file.
>
> Nick, I'd like this on the branch too please.
>
> bfd/
> * elf-bfd.h (_bfd_elf_ppc_merge_fp_attributes): Update prototype.
> * elf32-ppc.c (_bfd_elf_ppc_merge_fp_attributes): Return error
> on mismatch. Remove "warning: " from messages. Track last bfd
> used to set tags.
> (ppc_elf_merge_obj_attributes): Likewise. Handle status from
> _bfd_elf_ppc_merge_fp_attributes.
> * elf64-ppc.c (ppc64_elf_merge_private_bfd_data): Handle status
> from _bfd_elf_ppc_merge_fp_attributes.
> ld/
> * testsuite/ld-powerpc/attr-gnu-4-12.d: Update expected output.
> * testsuite/ld-powerpc/attr-gnu-4-13.d: Likewise.
> * testsuite/ld-powerpc/attr-gnu-4-21.d: Likewise.
> * testsuite/ld-powerpc/attr-gnu-4-23.d: Likewise.
> * testsuite/ld-powerpc/attr-gnu-4-31.d: Likewise.
> * testsuite/ld-powerpc/attr-gnu-4-32.d: Likewise.
> * testsuite/ld-powerpc/attr-gnu-8-23.d: Likewise.
> * testsuite/ld-powerpc/attr-gnu-12-21.d: Likewise.
>
Approved for the branch.
Cheers
Nick