This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Allow emit-relocs with gc-sections

From: "Sriraman Tallam via binutils" <binutils at sourceware dot org>
To: Cary Coutant <ccoutant at gmail dot com>
Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Han Shen <shenhan at google dot com>, Brett Chalabian <bchala at google dot com>, binutils <binutils at sourceware dot org>
Date: Tue, 3 Jul 2018 16:58:27 -0700
Subject: Re: Allow emit-relocs with gc-sections
References: <CAAs8HmzcCNommgOa4cxF15TipvHMpgeH+TqyFiTmpnudU-YACw@mail.gmail.com> <CAAs8HmyNB_yM_oYvYniB2zpL6AGGxqkSJCqAxM2BaGtmoq=+Fw@mail.gmail.com>
Reply-to: Sriraman Tallam <tmsriram at google dot com>

Ping.

* object.cc (Sized_relobj_file<size, big_endian>::do_layout): Check
  if it is pass two or single pass when allowing emit relocs.
* testsuite/Makefile.am (gc_icf_emit_relocs_test): New test.
* testsuite/gc_icf_emit_relocs_test.cc: New test source.
* testsuite/gc_icf_emit_relocs_test.sh: New test.

On Tue, Jun 26, 2018 at 6:05 PM, Sriraman Tallam <tmsriram@google.com> wrote:
> Resending as plain text.
>
> * object.cc (Sized_relobj_file<size, big_endian>::do_layout): Check
>  if it is pass two or single pass when allowing emit relocs.
> * testsuite/Makefile.am (gc_icf_emit_relocs_test): New test.
> * testsuite/gc_icf_emit_relocs_test.cc: New test source.
> * testsuite/gc_icf_emit_relocs_test.sh: New test.
>
> On Tue, Jun 26, 2018 at 6:03 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>> Hi Cary,
>>
>>    This patch allows emit-relocs when gc-sections or icf is present.  Is
>> this alright?
>>
>> * object.cc (Sized_relobj_file<size, big_endian>::do_layout): Check
>>   if it is pass two or single pass when allowing emit relocs.
>> * testsuite/Makefile.am (gc_icf_emit_relocs_test): New test.
>> * testsuite/gc_icf_emit_relocs_test.cc: New test source.
>> * testsuite/gc_icf_emit_relocs_test.sh: New test.
>>
>> Thanks
>> Sri
>>

Attachment: gold_emit_relocs_patch.txt
Description: Text document

Follow-Ups:
- Re: Allow emit-relocs with gc-sections
  - From: Cary Coutant

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]